Re: system/3704: routed has byte ordering issues on non-network

[kindred@purdue.edu (Don Kindred)]

The following reply was made to PR system/3704; it has been noted by GNATS.

From: kindred@purdue.edu (Don Kindred)
To: otto@drijf.net (Otto Moerbeek)
Cc: gnats@openbsd.org
Subject: Re: system/3704: routed has byte ordering issues on non-network
Date: Wed, 10 Mar 2004 14:43:37 -0500 (EST)

 > - Please send unified diffs (diff -u), they are much easier to read.
 
 	Will do!
 
 > - Your diff makes routed deviate from both NetBSD and FreeBSD. Below is a
 > diff based on NetBSD, which should solve your problem, leaving the
 > arguments to getnet() both in host byte order. FreeBSD contains similar
 > changes. As you can read from getnetbyname(3), networks numbers are
 > normally processed in host byte order.  Please test (also the gateway file
 > and the -F option) and report back.
 
 	I tested your patch.  It works (both -p directive and gateways
 	file).  Your patch is indeed the better patch.
 
 	After reading the manpage 3 times I think I finally understand
 	what the -F option is supposed to do.  I tested the -F option
 	with your patch and it seems to do what the manpage documents.
 	(Normally I don't use the -F option.)
 
 	Thanks for your quick response and resolution!  I would have
 	gotten back to you sooner, but I was out of town yesterday.
 
 --Don
 
 Don Kindred			| Email:	kindred@purdue.edu
 AgIT, Purdue University		| Phone:	(765)496-6806