[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: openntpd and ntpq



* Brett Lymn <blymn@baesystems.com.au> [2004-09-04 14:24]:
> On Fri, Sep 03, 2004 at 01:16:46PM +0200, Henning Brauer wrote:
> > There is no point in transforming something to host byte order 
> > that is never used on the host.
> Currently never used, currently.  If someone decided to add to your
> code then they may introduce an endian sensitive bug by assuming the
> internal data is in host endian.  What you are doing violates the
> principle of least surprise - by doing that you lay the way open for
> bugs.

can you please go read up on the protocol? you are again posting 
complete bullshit.

as I explained before:

> > maybe the ntohl is not where YOU would expect it, but it's actually in 
> > a very logical place, in the function that converts from the ntp 
> > timestamp format to a double used internally.

the on-the-wire-format is completely unusable, so this is the perfect 
place to do that.

> I doubt if any of this will cause any change at all.  Just allow me to
> fill out an "I told you so" token that I can redeem on the occasion of
> the first endian bug that bites openntpd.

so go crawl back under your rock and wait for it. won't happen.