Re: openntpd and ntpq

[Theo de Raadt <deraadt@cvs.openbsd.org>]

> > Keep in network byte order until later.  Having structures which are
> > obviously on-the-wire order swap back and forth just creates more
> > chances for error.
> 
> Agreed - but you really need to make it obvious that the structures are
> in wire order.  The author may find it easy to distinguish but making
> it obvious would help someone else trying to maintain the code.

Cut the crap.  This has been discussed.  We do not do it that way ON
PURPOSE.

> >  You don't see people byte swapping IP addresses
> > in sockaddr's after getting them back from accept(), after all.
> 
> True... but you rarely do numerical operations on IP addreses.

Cut the crap.  We do it all the time.  It's called a netmask.