Re: games/xpat2

[naddy@mips.inka.de (Christian Weisgerber)]

Ian McWilliam <ianm@cit.uws.edu.au> wrote:

> That filename[64] should really be filename[MAXPATHLEN] and the
> appropriate include added if necessary.

Not from a security point of view.

> Where it gets this filename from should be checked throughly as
> it could potentially be passed a filename that is MAXPATHLEN from
> somewhere.

Look at the next 20 or so lines of code after the variable definition.
It's pretty safe.

However, the assumption throughout loadsave.c that sizeof(long)==4
is thoroughly broken.

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de