Re: kernel internals network driver question..

[Jason Ackley <jason@ackley.net>]

On Fri, 3 May 2002, Federico G. Schwindt wrote:

Thanks for the input/feedback..

>   if you look at mii_phy_add_media(), in OpenBSD doesn't print anything.
>   therefore, that's ok. what you see in ukphy is done in the attach routine,
> which urlphy does not have (judging for the diffs you provided).

 Yup, this was my bad.. Adjusted this section slightly (removed printf()).

>   are you using a recent kernel but an old ifconfig?

 ifconfig was/is up-to-date.

It seems my error was in the url_ioctl(). default: passes to ether_ioctl()
in NetBSD, while OpenBSD wanted to see it taken care of in url_ioctl()
(which ifconfig(8) calls with all the ioctls for 802.11 etc) or return a
EINVAL. (gleaned from from aue(4) and others).

Adjusted to return EINVAL from url_ioctl() if it didn't understand
the ioctl instead of sending it to ether_ioctl().

All seems better now:

url0 at uhub1 port 2
url0: Linksys Linksys USB LAN Adapter, rev 1.10/1.00, addr 3
url0: Ethernet address 00:10:60:c2:9b:71
urlphy0 at url0 phy 0: Realtek RTL8150L internal media interface

and even more important:

url0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
        media: Ethernet 100baseTX full-duplex
        status: active
        inet6 fe80::210:60ff:fec2:9b71%url0 prefixlen 64 scopeid 0x14

No funky nwid or powersave..

>   what are you waiting for? :)

 Step 1) make it work
 Step 2) write the manpage
 :)

 Patch now includes man pages for url(4) (based the NetBSD man page with
 some minor adjustments) and a simple urlphy(4) copied from an existing
 *phy man page.

>   there are plans to move it to if_ethersubr.c. i'm not sure why it has
> not happened yet, but it will prolly be done soon.

 Great! The new routine is mentioned at being faster on little
 endian.. A quick userland test program showed it to be quite true.

 I also tested the url(4) driver with an 802.1Q trunk to a cisco 2900
switch (which trunks to a Alteon 180, which trunks to another OpenBSD/i386
box with a gx(4) adapter).

Basic ICMP and scp worked, when I netperf'ed I ran into mclpool issues,
even after adjusting NMBCLUSTERS to 8192. The chip itself only has 18K
of TX/RX buffering (2k Tx, 16k RX) so it may be falling over with the
addition of the VLAN tags.

I have let it running netperf non-tagged for upwards of 20min/1Gigabyte of
traffic..

The driver is ALTQ-enabled, but I have not yet tested it.. (want to get
the VLAN stuff going smoother first)

The patch has been updated to include the url_ioctl() fix, fix the blank
urlphy: line, new man pages and the minor mods that go with it(Makefile
updates, Xrefs etc).

Should be ready for anyone else that wants to test it now :)


The updated patch (76Kbytes, updated ~04:20 GMT) is located at the same
place  http://www.ackley.net/~jason/obsd-rtl8150.patch



cheers,
--
jason