[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: monitoring OpenBSD



On Wed, Aug 28, 2002 at 08:12:32AM +0200, Willem Dijkstra wrote:

> The entire thing was written on i386, but it was build to work on other
> architectures. I'd be must gratefull if someone could spare the time to
> try that out. Constructive comments/criticism on the package is much
> appreciated as well.

monmux segfaults on macppc, in share.c master_resetsem(). The fourth
argument to semctl(2) is not int, but union semun, so I suggest you
change all instances of

  semctl(semid, x, y, i) != 0)

to

  union semun arg;
  arg.val = i;
  if (semctl(semid, x, y, arg) != 0)

which resolves the problem on macppc. I'm not very familiar with
semaphores, and they seem to be not widely used on OpenBSD, but you can
check example usage in /usr/src/usr.sbin/httpd/src/main/http_main.c,
for instance.

mon(8) and monmux(8) have inconsistent options in SYNOPSIS (-v vs.
-a/-f).

c_monrrds.sh does only contain i386 specific interfaces, not gem or kue
that exist for instance on macppc.

Otherwise it looks very nice, I'll let you know when I have made the
first graphs :)

Daniel