Re: FYI: monitoring OpenBSD

[Willem Dijkstra <wpd@xs4all.nl>]

Daniel Hartmeier <daniel@benzedrine.cx> writes:

> monmux segfaults on macppc, in share.c master_resetsem(). The fourth
> argument to semctl(2) is not int, but union semun, so I suggest you
> change all instances of
>
>   semctl(semid, x, y, i) != 0)
> 
> to
> 
>   union semun arg;
>   arg.val = i;
>   if (semctl(semid, x, y, arg) != 0)

Check. Done, will upload new tarball after I incorporate the other
changes that you suggested in subsequent emails (alignment issues on
macppc and sparc) :)

> mon(8) and monmux(8) have inconsistent options in SYNOPSIS (-v vs.
> -a/-f).

-a is a typo. Right now, monmux allows a custom configfile anywhere via
-f, and mon does not (only /etc/mon.conf) because it runs as root. (I
know, this is a rather lame argument) I'll add the -f flag to mon when
everything is moved to sysctls and being root is no longer necessary.

> c_monrrds.sh does only contain i386 specific interfaces, not gem or kue
> that exist for instance on macppc.

doh! Added sparc and macppc devices to c_monrrds.sh.

> Otherwise it looks very nice, I'll let you know when I have made the
> first graphs :)

Excellent.

Cheers Daniel!

Willem