[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ipfilter proposed changes
>But the daemon-mode is broken and does not work with the '-s' (syslog)
>option:
Agreed, but! The modification should be made to the section that handles
the 's' option shouldn't it? Like say setting log=NULL or something? The
problem is that the case statement leaves 'log' in the default state and
that later on it's value becomes important. A lousy situation... Any better
ideas?
I propose this patch instead.
Index: ipmon.c
===================================================================
RCS file: /cvs/src/usr.sbin/ipmon/ipmon.c,v
retrieving revision 1.13
diff -u -r1.13 ipmon.c
--- ipmon.c 1998/09/15 10:01:39 1.13
+++ ipmon.c 1998/09/16 22:03:07
@@ -762,6 +762,7 @@
case 's' :
openlog(argv[0], LOG_NDELAY|LOG_PID, LOGFAC);
opts |= OPT_SYSLOG;
+ log=NULL;
break;
case 'S' :
opts |= OPT_STATE;
=====
Matthew Patton, 1LT USAF Webmaster, Resource Analysis
PGP Fingerprint: 17D4 98B1 51F1 BCD9 D815 5F3D 3B1C 5C26 762C C9C9
Key ID: 0x762CC9C9 Expires: 7/31/99