Re: bgpd dumps core

[Henning Brauer <lists-openbsdbugs_(_at_)_bsws_(_dot_)_de>]

* Alexey E. Suslikov <cruel_(_at_)_texnika_(_dot_)_com_(_dot_)_ua> [2005-04-17 17:35]:
> bgpd dumps core (even while bgpd -n) if any allow/deny
> filter specified.

oups.

Index: parse.y
===================================================================
RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v
retrieving revision 1.159
diff -u -p -r1.159 parse.y
--- parse.y	13 Apr 2005 21:16:22 -0000	1.159
+++ parse.y	17 Apr 2005 16:34:39 -0000
@@ -2105,7 +2105,7 @@ expand_rule(struct filter_rule *rule, st
 		free(a);
 	}
 
-	while ((s = SIMPLEQ_FIRST(set)) != NULL) {
+	while (set != NULL && (s = SIMPLEQ_FIRST(set)) != NULL) {
 		SIMPLEQ_REMOVE_HEAD(set, entry);
 		free(s);
 	}

-- 
BS Web Services, http://www.bsws.de/
OpenBSD-based Webhosting, Mail Services, Managed Servers, ...
Unix is very simple, but it takes a genius to understand the simplicity.
(Dennis Ritchie)