[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: devel/cscope vuln + update



m. kolb <muk_(_at_)_bender_(_dot_)_cl_(_dot_)_msu_(_dot_)_edu> wrote:

> ++int     temp2fd = -1;           /* temporary file descriptor */
> ++int     temp2fd = -1;           /* temporary file descriptor */

While this is a harmless typo, it makes me wonder whether you ever
tested your change.

Also, any reason not to just take the fix from the upstream repository
(revision 1.33->1.34)?  This isn't an entirely rhetoric question;
if the upstream fix is bad, we'll still need to replace it in a
future update.

-- 
Christian "naddy" Weisgerber                          naddy_(_at_)_mips_(_dot_)_inka_(_dot_)_de



Visit your host, monkey.org