[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

ipfilter proposed changes



Some have asserted that it's in poor taste to print kernel messages each
time the filter get's initialized. While I agree in a certain extent, I do
find the message, as a configuration/status update, useful nonetheless. I
would like to:

1) move the "already enabled" message to the ipf program itself.
2) add a "ipfilter en/disabled" message to ipf
3) use syslog to send the above messages
4) add a IPFILTER_MESSAGES kernel option (yeah, like we need another but...)
5) change "logging enabled/disabled" to "available/unavailable" since it is
more correct. Doesn't matter if logging is enabled unless ipmon is running,
you won't get any logs.

In fil.c we have:
#if (defined(_KERNEL) || defined(KERNEL)) && !defined(linux)
# include <sys/systm.h>
#else
# include <stdio.h>
# include <string.h>
# include <stdlib.h>
#endif

shouldn't that be?
#if (defined(_KERNEL) || defined(KERNEL))
# if !defined(linux)
#  include <sys/systm.h>
# else
#  include <stdio.h>
#  include <string.h>
#  include <stdlib.h>
# endif
#endif

No userland program I could find uses fil.c. I suspect though that the
#else bit is entirely unnecessary but have no alternative platforms against
which to test.

I've mailed Darren about these. I'll see what he comes up with.

=====
 Matthew Patton, 1LT USAF	Webmaster, Resource Analysis
 PGP Fingerprint: 17D4 98B1 51F1 BCD9 D815  5F3D 3B1C 5C26 762C C9C9
          Key ID: 0x762CC9C9    Expires: 7/31/99

Visit your host, monkey.org