[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch:] restore the native use of isdigit() instead of ap_isdigit() in httpd.
- To: tech_(_at_)_openbsd_(_dot_)_org
- Subject: Re: [Patch:] restore the native use of isdigit() instead of ap_isdigit() in httpd.
- From: joerg_(_at_)_britannica_(_dot_)_bec_(_dot_)_de
- Date: Thu, 30 Mar 2006 22:37:45 +0200
- Mail-followup-to: tech_(_at_)_openbsd_(_dot_)_org
On Thu, Mar 30, 2006 at 03:20:44PM -0500, Daniel Ouellet wrote:
> OK, that's fair. So, if I understand you right then, I will redo the
> changes and anywhere that is might not be already (unsigned char), you
> would suggest that I called it like this for example then and the
> results would be the same as it is now using the ap_isdigit() one.
Exactly. It might help you to remove the explicit cast in ctype.h for
testing, GCC should warn about char used as index.
Joerg
Visit your host, monkey.org